Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue in Safari with Equation References #86

Open
sayaikegawa opened this issue Jan 8, 2021 · 4 comments
Open

Issue in Safari with Equation References #86

sayaikegawa opened this issue Jan 8, 2021 · 4 comments
Assignees

Comments

@sayaikegawa
Copy link

Hi @mmcky , I'm really sorry my work delay and I'll catch up.

I found a potential issue about equation references in all lectures. (e.g. Equation(9.1))

When I click an equation reference in MYST, the referred equation is concealed by the upper menu bar.

This shows a comparison when I click the same equation reference. ( left: clicking Equation(1) in RST, right: clicking Equation(9.1) in MYST)
Screen Shot 2021-01-08 at 6 44 38 pm

I wonder whether it can be fixed in some ways. ( For example, I wonder whether the upper menu bar can be invisible depending on users' cursor's position.)

@sayaikegawa sayaikegawa changed the title [lecture_comparison] [lecture_comparison]equation references Jan 8, 2021
@mmcky
Copy link
Contributor

mmcky commented Jan 8, 2021

thanks @sayaikegawa (cc: @DrDrij)

@mmcky
Copy link
Contributor

mmcky commented Jan 13, 2021

@DrDrij @AakashGfude is there a way to improve this issue re: alignment of math links.

@DrDrij
Copy link
Member

DrDrij commented Feb 12, 2021

Since we have a sticky toolbar we need to add padding at the top, but this padding also needs to exist for skip anchor links in the content.

Tried all the following without luck: https://css-tricks.com/hash-tag-links-padding/

@mmcky I've added a solution which works cleanly in chrome and firefox for now.
4ac9e17

https://60263686dc45de7dbd694187--hungry-lovelace-7d0512.netlify.app

@mmcky
Copy link
Contributor

mmcky commented Feb 15, 2021

Thanks @DrDrij given this is an issue in safari I will transfer this issue to quantecon-book-theme for tracking

@mmcky mmcky transferred this issue from QuantEcon/lecture-python.myst Feb 15, 2021
@mmcky mmcky changed the title [lecture_comparison]equation references Issue in Safari with Equation References Feb 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants