Skip to content

Review Security SetModel Python Wrapper Handling #9053

@Martin-Molinero

Description

@Martin-Molinero

Expected Behavior

  • Python model wrapper is only used when required

Actual Behavior

  • if the user provides a pure C# instance we don't need a wrapper and it is being used, see SetFeeModel

Potential Solution

  • Review existing handling in QCAlgorithm, we already check in different location whether an instance is pure C# or not and handle it correctly
    • ideally we should centralize this logic in a helper method

Reproducing the Problem

security.set_fee_model(ConstantFeeModel(0))

See related #7925

System Information

N/A

Checklist

  • I have completely filled out this template
  • I have confirmed that this issue exists on the current master branch
  • I have confirmed that this is not a duplicate issue by searching issues
  • I have provided detailed steps to reproduce the issue

Metadata

Metadata

Assignees

Labels

No labels
No labels

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions