From c9567324525114ef0e4f2f27ea8027ab3b259e2a Mon Sep 17 00:00:00 2001 From: Sebastian Messmer Date: Mon, 11 Feb 2019 12:29:47 -0800 Subject: [PATCH] Revert unneeded fixes in flat_hash_map (#16907) Summary: Pull Request resolved: https://github.com/pytorch/pytorch/pull/16907 The begin()/end() fix actually doesn't make sense, see my comment on https://github.com/skarupke/flat_hash_map/pull/8 This diff removes it. Reviewed By: ezyang Differential Revision: D13985779 fbshipit-source-id: f08b02c941069e2a4e728e02a19b65dc72f96b41 --- c10/util/flat_hash_map.h | 3 --- 1 file changed, 3 deletions(-) diff --git a/c10/util/flat_hash_map.h b/c10/util/flat_hash_map.h index 2e46452af3eb7..96da0701e2d5a 100644 --- a/c10/util/flat_hash_map.h +++ b/c10/util/flat_hash_map.h @@ -1,6 +1,5 @@ // Taken from https://github.com/skarupke/flat_hash_map/blob/2c4687431f978f02a3780e24b8b701d22aa32d9c/flat_hash_map.hpp // with fixes applied: -// - https://github.com/skarupke/flat_hash_map/pull/8 // - https://github.com/skarupke/flat_hash_map/pull/25 // - https://github.com/skarupke/flat_hash_map/pull/26 // - replace size_t with uint64_t to fix it for 32bit @@ -522,7 +521,6 @@ class sherwood_v3_table : private EntryAlloc, private Hasher, private Equal if (it->has_value()) return { it }; } - return end(); } const_iterator begin() const { @@ -531,7 +529,6 @@ class sherwood_v3_table : private EntryAlloc, private Hasher, private Equal if (it->has_value()) return { it }; } - return end(); } const_iterator cbegin() const {