-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
min/max for complex inputs #67
Comments
A similar issue exists for sorting and searching: #65 (review) and #65 (comment) suggest to just disallow it:
I think numpy does essentially a lexicographic ordering: compare real parts and break ties with the imaginary part. Not sure though, and would rather agree that an arbitrary decision on how to impose order in the complex plane best needs a motivating use case. |
+1 to disallow |
added to the list of current limitations in gh-73 |
This is tracked / mentioned on gh-73, so let's close this. |
Pytorch throws
RuntimeError: "min_values_cpu" not implemented for 'ComplexDouble'
. Numpy does something: looks like it compares the real part and breaks ties with the imaginary part.There are some tests in
numpy_tests/core/test_multiarray.py::TestArgmax::test_combinations
and...::TestArgmin::...
The text was updated successfully, but these errors were encountered: