Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add an option to pass patient/study/equipment etc via JSON #56

Closed
fedorov opened this issue Aug 2, 2016 · 5 comments
Closed

Add an option to pass patient/study/equipment etc via JSON #56

fedorov opened this issue Aug 2, 2016 · 5 comments
Assignees

Comments

@fedorov
Copy link
Member

fedorov commented Aug 2, 2016

The idea is the following:

  • give user an option to either specify source DICOM files to carry forward composite context, or specify individual modules
  • when possible, assign default values to allow for conversion even if source data is not available
  • to manage complexity, include only attributes listed as Type 1 or 2, skip Type 3 or conditionals

Known deficiency, out of many I am sure, this "parameterization" is lossy with respect to the standard, as it does not communicate modules completely, and does not preserve their definition (Type) completeness. The motivation for this is to reduce complexity, and handle only the attributes that are of interest for the QI applications.

Related to #44

@fedorov fedorov added this to the SR/SEG/PM converters release milestone Aug 2, 2016
@fedorov fedorov self-assigned this Aug 2, 2016
@che85
Copy link
Member

che85 commented Aug 2, 2016

related to #38

@fedorov
Copy link
Member Author

fedorov commented Aug 17, 2016

I am thinking to remove this issue from the milestone, and keep the requirement of input DICOM files for now

@che85
Copy link
Member

che85 commented Aug 17, 2016

Makes sense. I guess that would be much more thinking and work.

@fedorov fedorov removed this from the SR/SEG/PM converters release milestone Aug 17, 2016
@fedorov
Copy link
Member Author

fedorov commented Sep 11, 2016

a related observation - the way composite context is passed to the converters is different between tid1500, seg and paramap converters; this will need to be fixed.

@fedorov
Copy link
Member Author

fedorov commented Jan 30, 2024

The essence of this request (passing composite context without having access to a DICOM file containing it) will be addressed by #390.

@fedorov fedorov closed this as not planned Won't fix, can't repro, duplicate, stale Jan 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants