Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Additional wastwater_nodes not exported with Limit to selection #93

Open
1 task
sjib opened this issue Dec 9, 2022 · 0 comments
Open
1 task

Additional wastwater_nodes not exported with Limit to selection #93

sjib opened this issue Dec 9, 2022 · 0 comments
Assignees
Labels
bug Something isn't working

Comments

@sjib
Copy link
Contributor

sjib commented Dec 9, 2022

Describe the bug
When using the option "Limit to selection" additional wastewater_nodes in a wastewater_structure (manhole, special_structure, ...) are not exported.

To Reproduce
Exact steps to reproduce the behavior:

  1. Go to layer vw_qgep_wastewater_structure
  2. Select some wastewater_structures with the Selection tool or a filter
  3. Go to layer vw_qgep_reach
  4. Add some reaches with the Selection tool or a filter
  5. Click on the INTERLIS Export button
  6. Choose Limit to selection
  7. Check the exported xtf file

20221209_additonal_wastewater_nodes_missing1
20221209_additonal_wastewater_nodes_missing2

Expected behavior
All wastewater_nodes of a structure should be exported, else the network is not complete and cannot be correctly imported in e.g. hydraulic simulation software. A selection of e.g. only PAA network is a specific current use case for using the selection.

Screenshots / data
vw_ggep_reach contains only the information of one wastewater_node per wasterwater_structure (I guess the main_wastewater_node)

It looks like the the filter criteria only takes the id's of the wastewater_nodes in vw_qgep_reach

query = query.filter(QGEP.wastewater_networkelement.obj_id.in_(subset_ids))

Suggestion:
Change this criteria to select all connected wastewater_nodes of selected wastewater_structures:
new:
query = query.filter(QGEP.wastewater_networkelement.fk_wastewater_structure.in_(subset_ids))

to do:

  • Check whether the same thing is true with channels that have several reaches. Then maybe the same approach could be used.

Current workaround
Use export without selection to get all wastewater_nodes

Desktop (please complete the following information):

  • QGEP plugin version 1.5.6
  • QGEP datamodel version 1.5.5
  • QGEP project file version latest
  • QGIS Version 3.23
  • OS Windows 10
@sjib sjib added enhancement New feature or request bug Something isn't working and removed enhancement New feature or request labels Jan 19, 2023
@sjib sjib self-assigned this Jan 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant