Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add check of QGEP/QWAT datamodel version #53

Open
olivierdalang opened this issue Sep 15, 2021 · 2 comments
Open

Add check of QGEP/QWAT datamodel version #53

olivierdalang opened this issue Sep 15, 2021 · 2 comments
Assignees
@olivierdalang
Labels
enhancement New feature or request
Milestone
one day

Comments

@olivierdalang
Copy link
Collaborator

The tool is only supposed to work on latest versions of QGEP/QWAT (1.5.6/1.3.6 respectively).

This should be documented.

Additionally, we should include a check before importing/exporting, throwing an error early if it doesn't match, to avoid unexpected/cryptic issues.
@olivierdalang olivierdalang mentioned this issue Sep 15, 2021
Closed
@olivierdalang olivierdalang added the documentation Improvements or additions to documentation label Sep 15, 2021
@olivierdalang olivierdalang self-assigned this Sep 15, 2021
@olivierdalang olivierdalang added this to the intial release milestone Sep 15, 2021
@olivierdalang
Copy link
Collaborator Author

Added docs both in readme and QGEP docs.

Leaving this open for future enhancement (checking version from the pum info table).

@olivierdalang olivierdalang modified the milestones: intial release, one day Sep 15, 2021
@olivierdalang olivierdalang removed the documentation Improvements or additions to documentation label Sep 15, 2021
@olivierdalang olivierdalang changed the title Clarify what version of QGEP and QWAT are supported Add check of QGEP/QWAT datamodel version Sep 15, 2021
@sjib sjib added the enhancement New feature or request label Apr 7, 2022
@sjib
Copy link
Contributor

sjib commented Aug 16, 2022

Use this function def _get_current_version(self): that is already implemented in the data model tool:
https://github.com/QGEP/qgepplugin/blob/ba90cf3cdafa811ce76737cd9e5b69037c4e8e0e/qgepplugin/gui/qgepdatamodeldialog.py#L358

@sjib sjib mentioned this issue Mar 4, 2023
Open
1 task
olivierdalang added a commit that referenced this issue Mar 9, 2023
@olivierdalang
fix #53: add a check for the datamodel version
6354e44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@olivierdalang olivierdalang

Labels
enhancement New feature or request
Projects
None yet
Milestone
one day
Development

No branches or pull requests
2 participants
@sjib @olivierdalang