Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include class name for warnings #117

Open
cymed opened this issue Apr 14, 2023 · 3 comments
Open

Include class name for warnings #117

cymed opened this issue Apr 14, 2023 · 3 comments
Assignees
Labels
enhancement New feature or request

Comments

@cymed
Copy link

cymed commented Apr 14, 2023

Describe the bug
In qgepqwat2ili, missing mandatory values are logged with the warning
"WARNING A mandatory value was null. It will be cast to a blank string, and probably cause validation errors"
yet there is no information on which layer is affected.

To Reproduce
Exact steps to reproduce the behavior:

  1. export an Interlis from a database with errors
  2. See error
  3. Check logs

Expected behavior
The warning should be extended to "WARNING A mandatory value (attribute name) in the layer (layer_name) was null. It will be cast to a blank string, and probably cause validation errors"

Screenshots / data
dump can be sent by email upon request

Desktop (please complete the following information):

  • QGEP plugin version 20230411 test vsa-dss
  • QGEP datamodel version 1.6.0
  • QGEP project file version 1.6.1
  • QGIS Version 3.28.5 LTR
  • sqlalchemy Version 1.3.24
  • geoalchemy2 Version 0.11.1
@sjib
Copy link
Contributor

sjib commented Apr 14, 2023

@cymed The function null_to_empty is only used for the attribut "identifier/Bezeichnung" as this is the only attribute besides obj_id that is MANDATORY in INTERLIS - see export.py

I am currently testing a new check to see if there are missing identifiers - see https://github.com/QGEP/qgepqwat2ili/pull/108/files#r1166864199

@cymed
Copy link
Author

cymed commented Apr 14, 2023

NULL entries on ws_status can also lead to problems, even if the field is not mandatory.

@sjib
Copy link
Contributor

sjib commented Apr 14, 2023

@cymed Can you post an example?

@sjib sjib self-assigned this Apr 19, 2023
@sjib sjib added the enhancement New feature or request label Apr 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants