Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

INTERLIS-Export: dataowner and provider are not implemented #113

Open
urskaufmann opened this issue Mar 14, 2023 · 6 comments
Open

INTERLIS-Export: dataowner and provider are not implemented #113

urskaufmann opened this issue Mar 14, 2023 · 6 comments
Assignees
Labels
enhancement New feature or request

Comments

@urskaufmann
Copy link

urskaufmann commented Mar 14, 2023

Describe the bug
Datenherr and Datenlieferant are exported always as unknown, also when there are values in this fields.

This is not a bug (it's documentated in the code), but the correct values are not implemented.

@sjib sjib transferred this issue from QGEP/QGEP Mar 25, 2023
@sjib sjib added bug Something isn't working enhancement New feature or request and removed bug Something isn't working labels Mar 25, 2023
@sjib
Copy link
Contributor

sjib commented Mar 25, 2023

See #36 for more background and considerations

@sjib
Copy link
Contributor

sjib commented Mar 29, 2023

Needs adaption here:
datenherr=getattr(row.fk_dataowner__REL, "name", "unknown"), # TODO : is unknown ok ?
datenlieferant=getattr(row.fk_provider__REL, "name", "unknown"), # TODO : is unknown ok ?

See

def create_metaattributes(row):

Suggested Change Options:
a) Change "name" to "identifier" as there is no column "name" in qgep datamodel in class organisation to get the identifier in case there is no fk_ set
b) It should only set 'unknown' if there is no fk_provider set. Just add 'unknown' if there is no fk_ set (becaus if NULL then we get an error in the INTERLIS file) and else leave the foreignkey value

@sjib
Copy link
Contributor

sjib commented Mar 31, 2023

With identifier instead of name:
datenherr=getattr(row.fk_dataowner__REL, "identifier", "unknown"), # TODO : is unknown ok ?
datenlieferant=getattr(row.fk_provider__REL, "identifier", "unknown"), # TODO : is unknown ok ?

20230331_datenherr_datenlieferant_identifier_instead_name

@sjib
Copy link
Contributor

sjib commented Mar 31, 2023

With obj_id instead of name:
datenherr=getattr(row.fk_dataowner__REL, "obj_id", "unknown"), # TODO : is unknown ok ?
datenlieferant=getattr(row.fk_provider__REL, "obj_id", "unknown"), # TODO : is unknown ok ?

20230331_datenherr_datenlieferant_obj_id_instead_name

@sjib
Copy link
Contributor

sjib commented Mar 31, 2023

Please vote with thumb which of the two option should be implemented.

@sjib sjib self-assigned this Mar 31, 2023
@sjib
Copy link
Contributor

sjib commented Apr 12, 2024

Should be correct now with obj:

datenherr=getattr(row.fk_dataowner__REL, "obj_id", "unknown"), # TODO : is unknown ok ?

datenherr=getattr(row.fk_dataowner__REL, "obj_id", "unknown"), # TODO : is unknown ok ?

datenherr=getattr(row.fk_dataowner__REL, "obj_id", "unknown"), # TODO : is unknown ok ?

@urskaufmann Please check and confirm, then this can be closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants