Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add server-specific member banners #2516

Closed
ToothyDev opened this issue Aug 5, 2024 · 1 comment · Fixed by #2556
Closed

Add server-specific member banners #2516

ToothyDev opened this issue Aug 5, 2024 · 1 comment · Fixed by #2556
Labels
Failing API Reflection feature request New feature request good first issue Good for newcomers priority: high High Priority status: todo This issue needs work
Milestone
v2.7

Comments

@ToothyDev
Copy link

Summary

It isn't possible to access a member's server specific banner, if set

What is the feature request for?

The core library

The Problem

Currently, only Member.banner exists. This is different from avatars, where both Member.avatar and Member.display_avatar are implemented. This makes it impossible to access members' server-specific banners, as currently, Member.banner will always return their globally set banner

The Ideal Solution

Member.display_banner is added, making it possible to access members' server-specific banners if set

The Current Solution

No response

Additional Context

No response
@ToothyDev ToothyDev added the feature request New feature request label Aug 5, 2024
@Lulalaby Lulalaby added priority: high High Priority status: todo This issue needs work Failing API Reflection labels Aug 5, 2024
@Lulalaby Lulalaby added this to the v2.7 milestone Aug 5, 2024
@plun1331 plun1331 removed their assignment Aug 7, 2024
@plun1331
Copy link
Member

plun1331 commented Aug 7, 2024

Someone else take care of this, I'm on vacation :p

@JustaSqu1d JustaSqu1d added the good first issue Good for newcomers label Aug 7, 2024
@MattyTheHacker MattyTheHacker mentioned this issue Aug 19, 2024
Merged
9 tasks
@Lulalaby Lulalaby linked a pull request Aug 19, 2024 that will close this issue
feat: Member.display_banner #2556
Merged
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Failing API Reflection feature request New feature request good first issue Good for newcomers priority: high High Priority status: todo This issue needs work
Projects
Pycord Releases
Status: Done
Milestone
v2.7
Development

Successfully merging a pull request may close this issue.

feat: Member.display_banner MattyTheHacker/pycord
4 participants
@Lulalaby @plun1331 @ToothyDev @JustaSqu1d