Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issues with Latest pyWiFeS Automation: LaTeX Activation, .tolist Method, and Missing AIRMASS #66

Open
3 tasks done
Ramiapp opened this issue Jul 15, 2024 · 1 comment

Comments

@Ramiapp
Copy link

Ramiapp commented Jul 15, 2024

Hi guys,
I'm using the latest update of PyWiFi's automated version and I found these issues.

  • 1. LaTeX Activation: (I think easy) I added latex=True in reduce.py, and in some cases, I had to modify the files directly.
  • 2. .tolist Not Working: (I think easy) I added .values.tolist() in data_classifier to resolve the issue.
  • 3. AIRMASS Not Found: This is a bit more challenging. The raw files do include the airmass in the header but not the created new files, resulting in a warning about no airmass detected. See below for the specific warning message:

2024-07-15 15:06:04 - PyWiFeS - WARNING - Failed to get airmass for image /Users//PhD/WiFeS_data/data_products/intermediate/blue/OBK-124992-WiFeS-Blue-UT20231011T070322-4.p01.fits: "Keyword 'AIRMASS' not found."
2024-07-15 15:06:05 - PyWiFeS - WARNING - Failed to get airmass for image..... for all files

@anuian
Copy link

anuian commented Jul 23, 2024

The AIRMASS is extracted in imcombine() but this throws and is caught when AIRMASS is not present. I think the real issue is that the warning message should be omitted unless the IMAGETYP keyword is OBJECT or STANDARD. Making the airmass 1.0 is convenient for computing the mean but leaving the list empty and not writing the AIRMASS to the output in that case would be a more faithful transfer from the source files being combined.

@Ramiapp Ramiapp closed this as completed Jul 23, 2024
@anuian anuian reopened this Jul 23, 2024
@felipeji felipeji mentioned this issue Jul 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants