Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request: Option to set VHDL version #42

Closed
gts-bzi opened this issue Jul 6, 2024 · 2 comments
Closed

Feature request: Option to set VHDL version #42

gts-bzi opened this issue Jul 6, 2024 · 2 comments

Comments

@gts-bzi
Copy link
Contributor

gts-bzi commented Jul 6, 2024

Vivado requires to explicitly set the VHDL version to 2008+ if VHDL2008 features are being used in design files.
This might be solved in multiple ways:

  • Worst but fastest: Set all files to VHDL2008 by adding following line to vivado.jinja. This will likely not break anything and support VHDL2008 in addition, but is highly bodgy. set_property file_type {VHDL 2008} [get_files -filter {FILE_TYPE == VHDL}]
  • Reasonably easy: Add a new function to set VHDL version explicitly for all files.
  • Most effort but probably best: Implement both setting the version for all files + per each file add command.

I will probably implement this by myself when I find the time, so let me know before you start so we can avoid duplicate work :)

@rodrigomelo9
Copy link
Contributor

Hi @gts-bzi
I'm considering two things:

  • Add a general-purpose set_option method.
  • Add an options parameter in the add_<HDL> methods.
    In the meantime, you could use a hook:
    prj.add_hook('precfg', 'set_property file_type {VHDL 2008} [get_files -filter {FILE_TYPE == VHDL}]')

@rodrigomelo9
Copy link
Contributor

Closing, because we agreed (online meeting) it can be implemented using hooks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants