Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Install serve-d on demand #38

Open
aminya opened this issue Feb 24, 2021 · 1 comment
Open

Install serve-d on demand #38

aminya opened this issue Feb 24, 2021 · 1 comment
Labels

Comments

@aminya
Copy link
Member

aminya commented Feb 24, 2021

Integrate get-serve-d script into the the main code of the package instead of being an offline script

@aminya aminya self-assigned this Feb 24, 2021
@aminya aminya pinned this issue Feb 24, 2021
@aminya aminya unpinned this issue Feb 25, 2021
@aminya
Copy link
Member Author

aminya commented Feb 25, 2021

I feel like this approach is just more complex for no reason (e.g. all these manual downloading, decompressing, checking for versions, etc).

The better solution is to make an npm package for serve-d, so it can be easily installed as a dependency.

For now, I am going to bundle serve-d exe as part of the package.

Originally posted by @aminya in #40 (comment)

@aminya aminya added the wontfix label Feb 25, 2021
@aminya aminya removed their assignment Feb 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant