Installer complains about deprecated settings

[mattock]

Warning: Setting autosign is deprecated. 
   (location: /opt/puppetlabs/puppet/lib/ruby/vendor_ruby/puppet/settings.rb:1169:in `issue_deprecation_warning')
Warning: Setting ca is deprecated. 
   (location: /opt/puppetlabs/puppet/lib/ruby/vendor_ruby/puppet/settings.rb:1169:in `issue_deprecation_warning')

[mattock]

These complaints started with recent Puppet 5.x versions. These settings are in puppet.conf generated by the Foreman project's puppet modules. As Foreman needs to support Puppet 4, there may not be an easy way to make the upstream remove those settings. We may have to fork some of foreman's puppet modules or alternatively suppress these warnings by modifying the Kafo-generated puppet.conf or puppet command-line.

[mattock]

This problem can probably be circumvented by adding

disable_warnings=deprecations

to the puppet.conf that Kafo initially creates.

[mattock]

The deprecation warnings seem to be premature.

[mattock]

Also, the deprecation warnings appear after the first installer run, when the puppet modules have already configured puppet.conf.

[mattock]

The following patch removes all warnings:

--- puppet_strings_module_parser.rb     2018-09-26 10:26:48.788890570 +0000
+++ puppet_strings_module_parser.rb.new 2018-09-26 10:28:52.408890570 +0000
@@ -37,7 +37,7 @@
       @file = file = File.expand_path(file)
       raise KafoParsers::ModuleName, "File not found #{file}, check your answer file" unless File.exists?(file)

-      command = "#{self.class.puppet_bin} strings generate --emit-json-stdout #{file}"
+      command = "#{self.class.puppet_bin} strings generate --format json --disable_warnings=deprecations #{file}"
       @raw_json = `#{command}`
       unless $?.success?
         raise KafoParsers::ParseError, "'#{command}' returned error\n#{@raw_json}"

The --format json option was introduced in puppet-strings 1.2.0. Adapting the above command depending on puppet-string version is one way to resolve this.

[mattock]

Applying the above patch seems to fail with latest gem versions. Debug and resolve.