-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
format replacement species field #161
Comments
if anyone else isn't working on this, i would like to. |
thank you @isabelle-wagenvoord! sorry I missed your comment. no one's started work on this issue, you're more than welcome to go for it. the species attributes csv in the pipeline repository includes the species names. there's a related partial PR that explores how to add common/english names to the listed replacement species. I think @ian-r-rose has some thoughts about how to approach that problem, and as part of the solution, he recommended the work documented in issue #36 |
alright, thank you @emillipede ! |
examples of oddities in the "replacement species" field: https://public-tree-map.surge.sh/?id=10941912 https://public-tree-map.surge.sh/?id=10942416 https://public-tree-map.surge.sh/?id=10924429 @isabelle-wagenvoord |
Hi @emillipede, |
hi @isabelle-wagenvoord glad you made it home ok! one option is to look in the species attributes csv that's in the data pipeline repository. right now, there's no species json, but @ian-r-rose and I did talk about adding something like it |
thanks @emillipede! |
hi @isabelle-wagenvoord I'm sorry for the confusion, I'm not sure quite how to approach the problem. it seems like it may be faster to preprocess species name data, either as part of the existing json or in a companion json, rather than to parse it when a users loads the map. if some of this processing is done in the pipeline, then there could be some javascript code that recognizes species names (that are already indicated in one way or another) and adds specific formatting to text with species names. to include the next 5 years' worth of planting schedules, a lot of the data pipeline parsing needs updates. for now, I think makes sense to check in with @ian-r-rose about options for improving how species names are identified in the data pipeline (they could be included in those other updates). does that sound to you like an ok approach? |
hi @emillipede |
right now, the entire replacement species field in the "tree" view of the sidebar is italicized. the "vacant site" view has no italics. the only italics that should appear in these views are for the tree species names. other parts of the field should appear in regular text.
for example, the text in the replacement species field should appear as:
"Brahea armata, Pinus torreyana (east side only)" instead of
"Brahea armata, Pinus torreyana (east side only)"
I think this update will involve some data processing. I don't know how to start to address it. If you have ideas, please share.
The text was updated successfully, but these errors were encountered: