Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Force returning some variables in certain cases #39

Open
Moohan opened this issue Jul 18, 2022 · 0 comments
Open

Force returning some variables in certain cases #39

Moohan opened this issue Jul 18, 2022 · 0 comments
Labels
feature a feature request or enhancement good first issue ❤️ good issue for first-time contributors

Comments

@Moohan
Copy link
Member

Moohan commented Jul 18, 2022

If we're returning more than one years worth of data, we should always return the year variable, even if it wasn't specified in the columns argument.

Other cases would be, when recid or partnership etc. arguments are used, if we are returning more than one, always return the filtering variable. The current code will extract recid etc if it's needed for filtering but then not return it if it wasn't specifically asked for in the columns parameter.
@Moohan Moohan added feature a feature request or enhancement good first issue ❤️ good issue for first-time contributors help wanted ❤️ we'd love your help! labels Jul 18, 2022
@Moohan Moohan removed the help wanted ❤️ we'd love your help! label Dec 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature a feature request or enhancement good first issue ❤️ good issue for first-time contributors
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Moohan