Wrong default GroupName cause Exception

[dredhorse]

I did have Vanillifier installed and deleted the database and the setup.lock file to start fresh.

Connecting with a user will cause the Exception below.

Fix is to set

"DefaultRegistrationGroupName": "default",
"DefaultGuestGroupName": "guest",

• TShock version: 4.3.25
• TShock build number (if known):

Reproduction steps (if applicable)?

1. Some step
2. Some other step
3. Some bigger step
4. This is the problem

Any stack traces or error messages (if known)?

2020-06-30 16:53:21 - GetDataHandlers: ERROR: System.NullReferenceException: Object reference not set to an instance of an object
  at TShockAPI.TSPlayer.HasPermission (System.String permission) [0x0002b] in <f44a4fbe8d0f4b58851070e7c37b0c04>:0 
  at TShockAPI.Bouncer.OnGetSection (System.Object sender, TShockAPI.GetDataHandlers+GetSectionEventArgs args) [0x00088] in <f44a4fbe8d0f4b58851070e7c37b0c04>:0 
  at TShockAPI.HandlerList`1[T].Invoke (System.Object sender, T e) [0x00069] in <f44a4fbe8d0f4b58851070e7c37b0c04>:0 
  at TShockAPI.GetDataHandlers.OnGetSection (TShockAPI.TSPlayer player, System.IO.MemoryStream data, System.Int32 x, System.Int32 y) [0x0002b] in <f44a4fbe8d0f4b58851070e7c37b0c04>:0 
  at TShockAPI.GetDataHandlers.HandleGetSection (TShockAPI.GetDataHandlerArgs args) [0x00022] in <f44a4fbe8d0f4b58851070e7c37b0c04>:0 
  at TShockAPI.GetDataHandlers.HandlerGetData (PacketTypes type, TShockAPI.TSPlayer player, System.IO.MemoryStream data) [0x00017] in <f44a4fbe8d0f4b58851070e7c37b0c04>:0 

What plugins and what versions of those plugins are you running?

Vanillifier latest.

[Quinci135]

Vanillifier creates a group that is under zero restrictions gameplay wise, and moves everyone except superadmins to this group. Also, the default groups used for registered users & guests (defined in config) to the vanillified group.
When you purge your database, the group no longer exists so the server attempts to place anyone joining that is not a superadmin as this non-existent group but errors out.
*You could run the command again before letting anyone join and that should work fine

[dredhorse]

Hi, totally agree but tshock should handle a typo in the group names nicer as it is a user-configurable element that is prone to errors. Sanity checking of those values with detailed error messages helps a user which doesn't know coding a lot.

[hakusaro]

I did have Vanillifier installed and deleted the database and the setup.lock file to start fresh.

My official answer to this is "don't do this."

[dredhorse]

Vanillifier or deleting the database? It is a server with password protection for me and my 2 sons

[hakusaro]

In general if you're deleting the database that usually suggests that something is wrong -- if you just want to start fresh that's understandable, but it's definitely not expected for the config to break things if you remove the database but not db related changes. Is there something we can do to make things better? GitHub <[email protected]> wrote: “ Vanillifier or deleting the database? It is a server with password protection for me and my 2 sons — You are receiving this because you commented. Reply to this email directly, view it on GitHub, or unsubscribe.”

[dredhorse]

I totally agree that the fault is on my side, like I said all data from the config should be sanity checked before being used as the user can add anything he wants.

I know how hard that is as I had to work with people configuring Bukkit Plugins in yaml, I even wrote my own yaml checker to fix the most common issues before loading the yaml.

So for the group issue I mentioned pseudo code would look like:

get group from config
check if group exists
if not throw a descriptive error and shut down
if yes go ahead