Bad login attempt

[Marcus101RR]

What is the cause of this issue and how do I repair it? It only seems to affect a select few accounts, but not too many, but a significant amount of people are reporting this issue on my server and I am unable to resolve it. The only solution is for them to start a new account.

[hakusaro]

SSC?

[Marcus101RR]

Yes

User attempts all options:
/login Name password (correct password) -> Bad login attempt
/login -> Bad login Attempt
/login password -> Bad login attempt
/login wrongpassword -> Incorrect password

configs:
"DisableLoginBeforeJoin": false,
"DisableUUIDLogin": false,
"KickEmptyUUID": true,
"AllowRegisterAnyUsername": false,
"AllowLoginAnyUsername": true,

[hakusaro]

Where are they seeing the message?

[hakusaro]

It looks like your users aren't in a group that has tshock.account.login and therefore can't login. Are they maybe being assigned a group that doesn't have that permission?

[Marcus101RR]

by default they are assigned default and have login, I did create a custom code that migrates them to a custom temp group but inherits (or at least should) their parent group with still having the login node. I suppose I can isolate this bug and see if forcing to add that node will prevent this issue.

EDIT: But this doesn't happen until after login, so wonder why.

[hakusaro]

Okay, I'm dumb. Let me try again. It looks like you have AllowLoginAnyUsername enabled, and they need to have passed both username and password to login. E.g., /login maruchan whydoIalwaysrememberwhatcircularisinjapaneseitsbecauseofyoumaru.

The error only happens if the username is null or empty, and if the username parameter is nil, and the setting is enabled.

See

TShock/TShockAPI/Commands.cs

Line 792 in 8bd6d72

args.Player.SendErrorMessage("Bad login attempt.");

. TShock can't continue at this point because it can't locate an account to login to.

[Marcus101RR]

Analysis: Some users claim they have more than 1 account on my server, would this be the conflict (my theory is) the code is searching for the matching uuid of the account, first one it finds, and they happen to want to login to the second account. But this shouldn't trigger if they provide both username and password.

So I have 3 accounts:
Marcus101RR, Saiyan, Eggman
Can login fine with Marcus101RR or Eggman,
Saiyan however is always bad login attempt.

All with the same uuid, and password. So it seems Saiyan account is corrupted somehow.

[hakusaro]

Are you able to confirm if they're playing with vanilla terraria, or a mod loader of some kind?

[Marcus101RR]

It is Vanilla (this is all me doing this testing now) with the client and with a server. I have another inconsistency: https://imgur.com/a/fddzXuq

This time I removed Saiyan's TimeActive and UUID to null, and this happens. Eggman still works fine. I think this needs a one on one call because there is a big issue with tshock NOT finding accounts im specifying, or I have to send the sqlite db.

[hakusaro]

I think you should separate the two issues: if you're experiencing problems after changing the database UUID field to null that's kind of expected, to be honest.

If you can't replicate the issue at all even on the bugged accounts with the right & wrong passwords, I would say the problem can be narrowed down to the client, or a plugin or mod interfering with the chat text before it hits the TShock command processor.

The number one thing that we need to know is whether or not you can reproduce the exact issue without changing anything (ergo, do you ever get the bad login attempt doing the exact same commands?).

The TShock login system attempts to find accounts pretty rigorously. It would also be helpful if you can confirm that the database field for Saiyan's name is just ASCII Saiyan or if there are other characters stored (diacritics, non breaking spaces, etc).

[Marcus101RR]

There are other users who can replicate the issue without any interference. It isn't because I modified the db or not, it clearly is an issue that just appears out of the blue for users with alternative accounts. How do I check or send you the information regarding that entry?

[bartico6]

Issue was figured out to be a faulty tShock fork by yours truly, commaster

Can be closed.