Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot make on some systems (including Guix) #513

Open
ispringle opened this issue Dec 19, 2024 · 0 comments
Open

Cannot make on some systems (including Guix) #513

ispringle opened this issue Dec 19, 2024 · 0 comments

Comments

@ispringle
Copy link

ispringle commented Dec 19, 2024

When attempting to build this project I get the following error:

ian@voltaire ~/git/hub/ProtonMail/proton-bridge$ make build-nogui
cd ./utils/ && ./credits.sh bridge
/gnu/store/3jhfhxdf6v5ms10x5zmnl166dh3yhbr1-bash-minimal-5.1.16/bin/sh: ./credits.sh: /bin/bash: bad interpreter: No such file or directory
make: *** [Makefile:353: internal/bridge/credits.go] Error 126

Expected Behavior

I expect that the make file would at least start successfully and all shell scripts should either exit successfully or give an error relating to deps.

Current Behavior

Fails to run the associated shell files.

Possible Solution

The shebangs need to be updated to /usr/bin/env bash as not all environments provide bash at /bin.

There is already a PR (#327) in the works for this, although it's 2 years old and might need to be updated and surely needs to pull in master. Honestly might just be easier to run sed off the current master instead of trying to update this PR.

Steps to Reproduce

  1. Use an environment that does not provide bash at /bin
  2. Run make
  3. Feel sad

Version Information

3.15.1

Context (Environment)

Guix

Detailed Description

Write all the shebangs from #!/bin/[shell] to #!/usr/bin/env [shell].

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant