Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cell selection is not a rectangle when selecting a merged cell #222

Open
pekanboy opened this issue Apr 1, 2024 · 1 comment
Open

Cell selection is not a rectangle when selecting a merged cell #222

pekanboy opened this issue Apr 1, 2024 · 1 comment

Comments

@pekanboy
Copy link

pekanboy commented Apr 1, 2024 •
edited
Loading

There is a problem if you set the selection as follows (as in the video). Then the selection of cells will not be a rectangle. This is due to the fact that when executing cellsInRect, the rowSpan and colSpan attributes of cells are not taken into account.

Screen.Recording.2024-04-01.at.19.23.06.mov

Is it a bug that the selection is not rectangles or can I fix this bug?
@pekanboy
Copy link
Author

pekanboy commented Apr 2, 2024

Maybe need reconstruct the rectBetween function https://github.com/ProseMirror/prosemirror-tables/blob/master/src/cellselection.ts#L56

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@pekanboy