Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

iOS - Sticky toolbar does not stick #3

Open
marijnh opened this issue Dec 9, 2016 · 4 comments
Open

iOS - Sticky toolbar does not stick #3

marijnh opened this issue Dec 9, 2016 · 4 comments

Comments

@marijnh
Copy link
Member

marijnh commented Dec 9, 2016

See ProseMirror/prosemirror#223
@marijnh marijnh mentioned this issue Dec 9, 2016
Closed
@Dev1an
Copy link
Contributor

Dev1an commented Apr 11, 2019 •
edited
Loading

What about using sticky positioning in CSS instead of Javascript?

See:

@marijnh
Copy link
Member Author

marijnh commented Apr 11, 2019

Yes, we know about position: sticky. Back in 2016 it was terribly broken in iOS. Not sure what the current situation is.

@Dev1an
Copy link
Contributor

Dev1an commented Apr 11, 2019

The stickyness with CSS works on iOS. I tried it locally and it works fine. Shall I create a new pull request with this feature?

@marijnh
Copy link
Member Author

marijnh commented Apr 12, 2019

Sure! Though I think we'd want to keep the existing implementation for browsers where sticky isn't supported.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@marijnh @Dev1an