Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The menu buttons are spans, semantically they should be buttons #20

Open
canvaspixels opened this issue Jun 10, 2019 · 1 comment
Open

The menu buttons are spans, semantically they should be buttons #20

canvaspixels opened this issue Jun 10, 2019 · 1 comment

Comments

@canvaspixels
Copy link

canvaspixels commented Jun 10, 2019 •
edited
Loading

It would be great if the menu buttons were tabbable straight out of the box which you'll get for free if they're <button>s
@marijnh
Copy link
Member

marijnh commented Jun 11, 2019

I think they were, at one point, but I ran into issues with styling. A pull request that makes them buttons + makes them look the way they look now would be very welcome.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@marijnh @canvaspixels