Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

switch to using prod source system with CICD running (docs generated) #7

Merged
merged 21 commits into from
Sep 5, 2024
Merged

switch to using prod source system with CICD running (docs generated) #7

merged 21 commits into from
Sep 5, 2024

Conversation

mrmauer
Copy link
Collaborator

@mrmauer mrmauer commented Sep 3, 2024 •
edited
Loading

Final touches before publishing provider

  • switch to prod domain in client
  • all acceptance tests are succeeding
  • examples are cleaned up to provide reference on how to use each individual resource
  • set up CI/CD w/ live environment variables
  • end-to-end test go live flow with live DNS providers (custom_domain_verification resource) (tracked elsewhere)
  • fix any linter violations

@mrmauer mrmauer changed the title [WIP] switch to using prod source system switch to using prod source system with CICD running (docs generated) Sep 4, 2024
@mrmauer mrmauer marked this pull request as ready for review September 4, 2024 21:52
itailevi98
itailevi98 reviewed Sep 5, 2024
View reviewed changes
Copy link
Contributor

@itailevi98 itailevi98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

all lgtm (aside from the typos), i see that there are still some lint conflicts so ill keep this commented before approving

docs/resources/fe_integration.md Outdated Show resolved Hide resolved
docs/resources/roles_and_permissions.md Outdated Show resolved Hide resolved
internal/propelauth/client.go
Comment on lines -13 to 12
// TODO: FOR THE LOVE OF GOD, DON'T FORGET TO CHANGE THIS TO THE REAL URL.
const BaseURLTemplate string = "https://api.propelauth.com/iac/%s/project/%s"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🥇

itailevi98
itailevi98 previously approved these changes Sep 5, 2024
View reviewed changes
Copy link
Contributor

@itailevi98 itailevi98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@mrmauer
Copy link
Collaborator Author

mrmauer commented Sep 5, 2024

Bypass merging. Not meeting all requirements only b/c the CODEOWNERS file needs updating on the main branch.

@mrmauer mrmauer merged commit 9bf31f9 into main Sep 5, 2024
3 checks passed
@mrmauer mrmauer deleted the source-domain branch September 5, 2024 17:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@itailevi98 itailevi98 itailevi98 left review comments

@andrew-propelauth andrew-propelauth Awaiting requested review from andrew-propelauth

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mrmauer @itailevi98