Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unit tests should be unitary #150

Open
Ezibenroc opened this issue Mar 28, 2016 · 0 comments
Open

Unit tests should be unitary #150

Ezibenroc opened this issue Mar 28, 2016 · 0 comments
Labels
code style

Comments

@Ezibenroc
Copy link
Member

A lot of our unit tests rely on the output of CoreNLP. The best example of this is the file data.py which is mainly a copy-paste of what yields CoreNLP.
Because of this, any change in CoreNLP output implies to change our tests (it happened in #149).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
code style
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Ezibenroc