Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automatically mount jetpack #1290

Open
madsboddum opened this issue Apr 15, 2023 · 0 comments
Open

Automatically mount jetpack #1290

madsboddum opened this issue Apr 15, 2023 · 0 comments
Labels
FEATURE New feature or request good first issue Items marked with the good first issue label are intended for first-time contributors [Travel] Service Shuttle / Mounts / Vehicles

Comments

@madsboddum
Copy link
Member

madsboddum commented Apr 15, 2023

When calling out a jetpack, the player should be mounted to the jetpack automatically.

Pointers

Here's the method that's invoked when mounts are called: com.projectswg.holocore.services.gameplay.world.travel.PlayerMountService#callMount

And here's the method that can be invoked to enter a specified mount:
com.projectswg.holocore.services.gameplay.world.travel.PlayerMountService#enterMount

You can insert this method in the PlayerMountService class, to help determine if a given mount is a jetpack:

private boolean isJetpack(CreatureObject mount) {
	return "object/mobile/vehicle/shared_jetpack.iff".equals(mount.getTemplate()); 
}

With all this, you should be able to extend callMount, so that it invokes enterMount, if the mount is a jetpack.

@madsboddum madsboddum added the FEATURE New feature or request label Apr 15, 2023
@madsboddum madsboddum added the good first issue Items marked with the good first issue label are intended for first-time contributors label Jul 26, 2023
@Undercova Undercova pinned this issue Dec 1, 2023
@Undercova Undercova changed the title [Vehicle] Automatically mount jetpack Automatically mount jetpack Aug 18, 2024
@Undercova Undercova added the [Travel] Service Shuttle / Mounts / Vehicles label Aug 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
FEATURE New feature or request good first issue Items marked with the good first issue label are intended for first-time contributors [Travel] Service Shuttle / Mounts / Vehicles
Projects
None yet
Development

No branches or pull requests

2 participants