feat: display trust badge when product has only brand PPs

Author: vasiliy-pdk

src/__fixtures__/offers.tsx

@@ -26,6 +26,7 @@ export const offersSuccess = () => ({
   ],
 });
 
+// This happens when product doesn't have any proof points but its brand has
 export const offersNoProofPoints = () => ({
   trustBadge: {
     backgroundColor: '#dedede',

src/__tests__/api/index.test.tsx

@@ -69,7 +69,7 @@ describe('getOffers', () => {
   });
 
   describe('when proof points were not found', () => {
-    it('is not shown', async () => {
+    it('returns the fetched data', async () => {
       global.fetch = jest.fn(() => ({
         ok: true,
         json: () => Promise.resolve(offersNoProofPoints()),
@@ -78,9 +78,6 @@ describe('getOffers', () => {
       const result = await getOffers('fakeSku');
 
       expect(result).toEqual(offersNoProofPoints());
-      expect(Errors.warn).toHaveBeenCalledWith(
-        expect.stringContaining('No proof points found for the SKU: fakeSku')
-      );
     });
   });
 });

src/__tests__/index.test.tsx

@@ -83,14 +83,28 @@ describe('TrustBadge', () => {
   });
 
   describe('when proof points were not found', () => {
-    it('is not shown', async () => {
-      whenTrustBadgeRendered();
+    describe('when Tick variant', () => {
+      it('is still shown as success response from API without proof points indicates there are brand proof points', async () => {
+        whenTrustBadgeRendered();
 
-      await act(() => {
-        getOffersPromiseResolve(offersNoProofPoints());
+        await act(() => {
+          getOffersPromiseResolve(offersNoProofPoints());
+        });
+
+        expect(screen.root).toHaveTextContent(/Sustainability claims/i);
       });
+    });
 
-      expect(screen.root).not.toHaveTextContent(/Sustainability claims/i);
+    describe('when ProofPoint variant', () => {
+      it('is still shown as success response from API without proof points indicates there are brand proof points', async () => {
+        whenTrustBadgeRendered('ProofPoint');
+
+        await act(() => {
+          getOffersPromiseResolve(offersNoProofPoints());
+        });
+
+        expect(screen.queryAllByLabelText('Provenance logo')).toHaveLength(1);
+      });
     });
 
     describe('when no offers', () => {

src/api/index.tsx

@@ -122,11 +122,6 @@ export async function getOffers(sku: string): Promise<OffersData | null> {
         );
         return null;
       }
-      if (data.proofPoints.length === 0) {
-        Errors.warn(
-          `No proof points found for the SKU: ${sku}, it could be a valid case but better double check that the SKU is valid.`
-        );
-      }
       return data;
     } else {
       const message = await response.text();

src/trustBadge/index.tsx

@@ -95,8 +95,7 @@ const TrustBadgeComponent = ({
   const trustBadgeHeight =
     variant === 'Tick' ? Tick.getHeight() : ProofPoint.getHeight();
 
-  if (!offers || !offers.proofPoints || offers.proofPoints.length === 0)
-    return <></>;
+  if (!offers || !offers.proofPoints) return <></>;
 
   return (
     <View style={{ flexBasis: scaled(trustBadgeHeight) }}>