Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

As a content editor, I would like a new box in the footnote/source section of the document page specifically for "minor emendations" so that the notes field does not get messy. #1686

Open
4 tasks
richmanrachel opened this issue Nov 27, 2024 · 3 comments
Assignees
Labels
🆕 enhancement New feature or request

Comments

@richmanrachel
Copy link

richmanrachel commented Nov 27, 2024

testing notes (QA)

On the QA site admin:


Is your feature request related to a problem? Please describe.
In order to keep our data cleaner and more consistent, it would be good to have a dedicated box in the source section for "minor emendations by" [insert box to include creator name] and an emendations date box for month and year.
[See https://docs.google.com/spreadsheets/d/1JHscvhF6wEbX1Ep_SJaNm7VgCvMvo06-4F4RYyb6e2E/edit?gid=0#gid=0 for previous clean up needed]

Describe the solution you'd like
The following boxes in this order in Footnotes:

  • Source
  • Document relation
  • Location
  • Minor emendations by
  • Emendation date (Month/Year)
  • Notes [this box can be made smaller to indicate it should not be used frequently]
  • URL (Link to the source (optional))

Describe alternatives you've considered
@blms - if you think this is a bad idea, we can reconsider, but it seems like it might be the easiest way to handle this for the future.

Additional context

  • We will need to ensure that the code that put "minor emendations by" in the notes field re-routes to the new fields.
@blms
Copy link
Contributor

blms commented Jan 15, 2025

Started working on this, I've found a few things I wanted to flag/ask questions about based on the existing data:

  1. With this approach, we'd lose granularity in the citations about "emendations" being distinct from "revisions", "additions", "suggestions", etc. Would it be okay for that info to be stored separately in the notes field?
    • The citation would still read "with minor emendations by", and the notes field would be accessible only to content admins. So the public would miss out on the distinction, unless we devise some way to include the notes in the citations.
    • If we do store it there, it might actually make sense just to leave the notes field alone in all existing records, even if it's duplicative of the emendations field, to avoid losing any of this data.
  2. How should we handle cases like this one, with multiple people with different kinds of emendations?

    with minor emendations by Yaara Perlman and Joshua Picard, and with an edition of the Arabic verso by Marina Rustow

  3. Entering multiple names could also result in idiosyncratic citations in general, since people may not know what order to list them and whether to separate with a comma, etc. This could at least be alleviated by help text giving a standard way to list multiple people, and manually fixing nonstandard ones when encountered, but wanted to raise it as a potential issue.
  4. Same with multiple dates, e.g.

    With minor emendations by Marina Rustow, 3/16/23, and Alan Elbaum, 4/8/23

@blms
Copy link
Contributor

blms commented Jan 15, 2025

We will need to ensure that the code that put "minor emendations by" in the notes field re-routes to the new fields.

FWIW, in case it clears any confusion about why there's so much variance between the notes field contents, there isn't any code at play here currently! It's all manually entered so far.

@blms blms added the ❓ question Further information is requested label Jan 15, 2025
@blms blms removed the ❓ question Further information is requested label Feb 3, 2025
@blms
Copy link
Contributor

blms commented Feb 3, 2025

Questions answered in meeting 2/3:

  • Only one "With emendations by" field, no separate dates field. Help text will instruct how to enter dates, which is Person Name, Year.
  • It's ok that further granularity gets lost to the public, it can go in the notes.
  • Multiple names and multiple dates will be dealt with as they appear.

blms added a commit that referenced this issue Feb 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🆕 enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants