Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make fuller use of Serilog #680

Closed
rjmholt opened this issue Jun 7, 2018 · 1 comment
Closed

Make fuller use of Serilog #680

rjmholt opened this issue Jun 7, 2018 · 1 comment
Labels
Area-Test Issue-Enhancement A feature request (enhancement).

Comments

@rjmholt
Copy link
Contributor

rjmholt commented Jun 7, 2018

Serilog offers a rich template string interface for logging, but currently we have a single template and build strings for it.

@SeeminglyScience suggested we should instead implement an ITextFormatter for the various things we want to log.

In the original Serilog migration I made the following choices:

  • Contain Serilog references in a single part of the code
  • Maintain the old log level system rather than Serilog's
  • Use the ILogger interface still

Serilog has fairly rich functionality but because of the way its named-argument string templating works, I'm not sure it can be used indirectly.

But a good use of Serilog would probably involve us using it directly, with its log levels, and ideally using the log-level-named methods (logger.Verbose, logger.Error, etc.).

With this, we would probably want to use Serilog's ILogger rather than our own implementation.

We should also migrate the testing away from writing a text file and toward making test sink for Serilog.

@andyleejordan
Copy link
Member

andyleejordan commented Nov 15, 2024

Good bye Serilog, and good riddance! #2197

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-Test Issue-Enhancement A feature request (enhancement).
Projects
Status: Done
Development

No branches or pull requests

4 participants