Don't update PackageManagement on ConstrainedLanguage mode (#1288)

TylerLeonhardt · web-flow · commit f66a7d826438 · 2020-05-11T13:07:14.000-07:00
Co-authored-by: Tyler Leonhardt (POWERSHELL) &lt;tyleonha@microsoft.com&gt;
diff --git a/src/PowerShellEditorServices/Services/PowerShellContext/Handlers/GetVersionHandler.cs b/src/PowerShellEditorServices/Services/PowerShellContext/Handlers/GetVersionHandler.cs
@@ -87,7 +87,13 @@ private async Task CheckPackageManagement()
                     break;
                 }
 
-                _logger.LogDebug("Old version of PackageManagement detected. Attempting to update.");
+                _logger.LogDebug("Old version of PackageManagement detected.");
+
+                if (_powerShellContextService.CurrentRunspace.Runspace.SessionStateProxy.LanguageMode != PSLanguageMode.FullLanguage)
+                {
+                    _languageServer.Window.ShowWarning("You have an older version of PackageManagement known to cause issues with the PowerShell extension. Please run the following command in a new Windows PowerShell session and then restart the PowerShell extension: `Install-Module PackageManagement -Force -AllowClobber -MinimumVersion 1.4.6`");
+                    return;
+                }
 
                 var takeActionText = "Yes";
                 MessageActionItem messageAction = await _languageServer.Window.ShowMessage(new ShowMessageRequestParams
@@ -120,6 +126,7 @@ await _powerShellContextService.ExecuteScriptStringAsync(
 
                     if (errors.Length == 0)
                     {
+                        _logger.LogDebug("PackageManagement is updated.");
                         _languageServer.Window.ShowMessage(new ShowMessageParams
                         {
                             Type = MessageType.Info,
@@ -129,6 +136,7 @@ await _powerShellContextService.ExecuteScriptStringAsync(
                     else
                     {
                         // There were errors installing PackageManagement.
+                        _logger.LogError($"PackageManagement installation had errors: {errors.ToString()}");
                         _languageServer.Window.ShowMessage(new ShowMessageParams
                         {
                             Type = MessageType.Error,

Original file line number	Diff line number	Diff line change
`@@ -87,7 +87,13 @@ private async Task CheckPackageManagement()`
`87`	`87`	`break;`
`88`	`88`	`}`
`89`	`89`
`90`		`- _logger.LogDebug("Old version of PackageManagement detected. Attempting to update.");`
	`90`	`+ _logger.LogDebug("Old version of PackageManagement detected.");`
	`91`	`+`
	`92`	`+ if (_powerShellContextService.CurrentRunspace.Runspace.SessionStateProxy.LanguageMode != PSLanguageMode.FullLanguage)`
	`93`	`+ {`
	`94`	+ _languageServer.Window.ShowWarning("You have an older version of PackageManagement known to cause issues with the PowerShell extension. Please run the following command in a new Windows PowerShell session and then restart the PowerShell extension: `Install-Module PackageManagement -Force -AllowClobber -MinimumVersion 1.4.6`");
	`95`	`+ return;`
	`96`	`+ }`
`91`	`97`
`92`	`98`	`var takeActionText = "Yes";`
`93`	`99`	`MessageActionItem messageAction = await _languageServer.Window.ShowMessage(new ShowMessageRequestParams`
`@@ -120,6 +126,7 @@ await _powerShellContextService.ExecuteScriptStringAsync(`
`120`	`126`
`121`	`127`	`if (errors.Length == 0)`
`122`	`128`	`{`
	`129`	`+ _logger.LogDebug("PackageManagement is updated.");`
`123`	`130`	`_languageServer.Window.ShowMessage(new ShowMessageParams`
`124`	`131`	`{`
`125`	`132`	`Type = MessageType.Info,`
`@@ -129,6 +136,7 @@ await _powerShellContextService.ExecuteScriptStringAsync(`
`129`	`136`	`else`
`130`	`137`	`{`
`131`	`138`	`// There were errors installing PackageManagement.`
	`139`	`+ _logger.LogError($"PackageManagement installation had errors: {errors.ToString()}");`
`132`	`140`	`_languageServer.Window.ShowMessage(new ShowMessageParams`
`133`	`141`	`{`
`134`	`142`	`Type = MessageType.Error,`