Apply suggestions from Copliot

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>

Author: JustinGrote

src/PowerShellEditorServices/Services/Symbols/Visitors/SymbolVisitor.cs

@@ -50,8 +50,8 @@ public override AstVisitAction VisitCommand(CommandAst commandAst)
 
     public override AstVisitAction VisitFunctionDefinition(FunctionDefinitionAst functionDefinitionAst)
     {
-        // Treat filter the same as function: both get SymbolType.Function so they appear in the
-        // outline and support child symbols (variables, nested functions, etc.) in the hierarchy.
+        // Treat filter the same as function: both get SymbolType.Function so they use the same
+        // function-like symbol kind. Document-symbol inclusion and child hierarchy are determined elsewhere.
         SymbolType symbolType = functionDefinitionAst.IsWorkflow
             ? SymbolType.Workflow
             : SymbolType.Function;

test/PowerShellEditorServices.Test/Language/SymbolsServiceTests.cs

@@ -789,11 +789,19 @@ public void FindsSymbolsInFile()
             Assert.True(symbol.IsDeclaration);
 
             // Verify that a variable declared inside a filter is tracked as a declaration,
-            // allowing it to appear as a child of the filter in the LSP outline hierarchy.
+            // and that it is returned as a child of the filter in the LSP outline hierarchy.
             symbol = Assert.Single(symbols, i => i.Id == "var FilterVar");
             Assert.Equal("$FilterVar", symbol.Name);
             Assert.True(symbol.IsDeclaration);
 
+            DocumentSymbol filterDocumentSymbol = Assert.Single(
+                GetDocumentSymbols(FindSymbolsInMultiSymbolFile.SourceDetails),
+                i => i.Name == "AFilter");
+            DocumentSymbol filterVariableDocumentSymbol = Assert.Single(
+                filterDocumentSymbol.Children,
+                i => i.Name == "$FilterVar");
+            Assert.Equal(SymbolKind.Variable, filterVariableDocumentSymbol.Kind);
+
             symbol = symbols.Last(i => i.Type == SymbolType.Variable);
             Assert.Equal("var nestedVar", symbol.Id);
             Assert.Equal("$nestedVar", symbol.Name);