Honey bottle and all banner patterns are no longer replaced

Author: Polyana-Fontes

CHANGELOG.md

@@ -17,6 +17,8 @@ Click the link above to see the future.
   it will now be converted as 248:0 (minecraft:info_update) instead of 1:15 (stone with invalid data)
 - sweet_berries and shield are no longer replaced, they are obtainable in Nukkit 1.X now
 - Updated [Region-Manipulator to `2.0.0`][Region 2.0.0] from `1.1.0`.
+- Honey bottle and all banner patterns are no longer replaced, they aren't obtainable in Nukkit 1.X but 
+the server won't break if you have these items in your inventory anymore. 
 
 ### Fixes
 - [#78] Error parsing sign text: IllegalStateException: component must not be null

REPLACEMENTS.md

@@ -7,11 +7,6 @@ See also [the list of missing features](MISSING_FEATURES.md).
 
 | Name                   | Replacement   | Unsupported by  |
 | ---------------------- | ------------- | --------------- |
-| flower_banner_pattern  | air           | Nukkit 1.X      |
-| creeper_banner_pattern | air           | Nukkit 1.X      |
-| skull_banner_pattern   | air           | Nukkit 1.X      |
-| mojang_banner_pattern  | air           | Nukkit 1.X      |
-| globe_banner_pattern   | air           | Bedrock Edition |
 | spruce_sign            | oak_sign      | Nukkit 1.X      |
 | birch_sign             | oak_sign      | Nukkit 1.X      |
 | jungle_sign            | oak_sign      | Nukkit 1.X      |
@@ -24,7 +19,6 @@ See also [the list of missing features](MISSING_FEATURES.md).
 | Arrow of Slowness IV | Arrow of Slowness I | Bedrock Edition |
 | Arrow of Lucky         | Regular Arrow | Bedrock Edition |
 | Spectral Arrow         | Regular Arrow | Bedrock Edition |
-| honey_bottle           | mushroom_stew | Nukkit 1.X      |
 
 ## Blocks
 

src/main/kotlin/br/com/gamemods/j2nwc/internal/integrity-check.kt

@@ -84,9 +84,12 @@ internal fun checkIds() {
                 }
 
         if (type == "I") {
-            if (nukkitItemId.toInt() !in nukkitItemNames) {
+
+            val itemId = nukkitItemId.toInt()
+            if (itemId !in setOf(434, 736, 737) && itemId !in nukkitItemNames) {
                 println("The item $type,$nukkitItemId,$nukkitItemData is unsupported by Nukkit!\nItem: $item")
             }
+
         } else {
             if (nukkitItemId.toInt() !in nukkitBlockNames) {
                 println("The item-block $type,$nukkitItemId,$nukkitItemData is unsupported by Nukkit!\nItem: $item")

src/main/resources/bedrock-2-nukkit.properties

@@ -1094,17 +1094,17 @@ I,475,~=323,0
 I,476,~=323,0
 
 #globe_banner_pattern -> flower_banner_pattern (when supported by Nukkit, currently replace it to air)
-#I,434,4=434,2
+I,434,4=434,2
 
 #banner_pattern -> air
-I,434,0=0,0
-I,434,1=0,0
-I,434,2=0,0
-I,434,3=0,0
-I,434,4=0,0
+#I,434,0=0,0
+#I,434,1=0,0
+#I,434,2=0,0
+#I,434,3=0,0
+#I,434,4=0,0
 
 #honeycomb -> air
 #I,736,~=0,0
 
 #honey_bottle -> mushroom_stew
-I,737,~=282,0
+#I,737,~=282,0