Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lag/Crash while having WorldEdit (including FAWE) and PowerRanks installed #96

Open
ProJakob opened this issue Mar 27, 2024 · 0 comments

Comments

@ProJakob
Copy link

I've been here with a friend of mine before due to the same issue. PowerRanks permission lookup function seems to still be kinda slow. This can cause huge lag spikes when spamming tab completions because WorldEdit abuses this function by checking any tab completion for permissions many times. This behaviour of WorldEdit in combination with the slow permission lookup of PowerRanks allows easily timing out the server which causes it to crash with malicious modifications.

Maybe add a small caching feature that caches the lookup for 50-150 milliseconds? That would probably already speed it up enough. Another implementation of that cache could also include indefinitely caching results until some state changes like adding/removing ranks or permissions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant