From c8d9864891f7479e1e892950b7d2f3f0d3a6d2db Mon Sep 17 00:00:00 2001
From: Remi Gacogne <remi.gacogne@powerdns.com>
Date: Tue, 18 Jun 2024 17:02:56 +0200
Subject: [PATCH] dnsdist: Fix clang-tidy's warnings about const-correctness

---
 pdns/dnsdistdist/dnsdist-lua.cc | 2 +-
 pdns/dnsdistdist/dnsdist.cc     | 4 ++--
 2 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/pdns/dnsdistdist/dnsdist-lua.cc b/pdns/dnsdistdist/dnsdist-lua.cc
index 8449178a406c6..d62ab765ebc97 100644
--- a/pdns/dnsdistdist/dnsdist-lua.cc
+++ b/pdns/dnsdistdist/dnsdist-lua.cc
@@ -3221,7 +3221,7 @@ static void setupLuaConfig(LuaContext& luaCtx, bool client, bool configCheck)
   });
 
   luaCtx.writeFunction("reloadAllCertificates", []() {
-    for (auto& frontend : dnsdist::getFrontends()) {
+    for (const auto& frontend : dnsdist::getFrontends()) {
       if (!frontend) {
         continue;
       }
diff --git a/pdns/dnsdistdist/dnsdist.cc b/pdns/dnsdistdist/dnsdist.cc
index 1df9452273df3..5a6070ddc9d0c 100644
--- a/pdns/dnsdistdist/dnsdist.cc
+++ b/pdns/dnsdistdist/dnsdist.cc
@@ -3171,7 +3171,7 @@ static void startFrontends()
 
   std::vector<ClientState*> tcpStates;
   std::vector<ClientState*> udpStates;
-  for (auto& clientState : dnsdist::getFrontends()) {
+  for (const auto& clientState : dnsdist::getFrontends()) {
 #ifdef HAVE_XSK
     if (clientState->xskInfo) {
       dnsdist::xsk::addDestinationAddress(clientState->local);
@@ -3423,7 +3423,7 @@ int main(int argc, char** argv)
       g_rings.init(config.d_ringsCapacity, config.d_ringsNumberOfShards, config.d_ringsNbLockTries, config.d_ringsRecordQueries, config.d_ringsRecordResponses);
     }
 
-    for (auto& frontend : dnsdist::getFrontends()) {
+    for (const auto& frontend : dnsdist::getFrontends()) {
       setUpLocalBind(*frontend);
     }