From c3a20ca259f092213cc688e0d7207be7a0cecc8c Mon Sep 17 00:00:00 2001
From: Rosen Penev <rosenp@gmail.com>
Date: Mon, 9 Dec 2024 18:08:57 -0800
Subject: [PATCH] clang-analyzer: fix null pointer deref

Signed-off-by: Rosen Penev <rosenp@gmail.com>
---
 pdns/packethandler.cc | 10 ++++++----
 1 file changed, 6 insertions(+), 4 deletions(-)

diff --git a/pdns/packethandler.cc b/pdns/packethandler.cc
index ca6d263438c4..87d0da7a3f3c 100644
--- a/pdns/packethandler.cc
+++ b/pdns/packethandler.cc
@@ -942,10 +942,12 @@ void PacketHandler::addNSEC(DNSPacket& /* p */, std::unique_ptr<DNSPacket>& r, c
   DLOG(g_log<<"addNSEC() mode="<<mode<<" auth="<<d_sd.qname<<" target="<<target<<" wildcard="<<wildcard<<endl);
 
   if (d_sd.db == nullptr) {
-    if(!B.getSOAUncached(d_sd.qname, d_sd)) {
-      DLOG(g_log<<"Could not get SOA for domain"<<endl);
-      return;
-    }
+    return;
+  }
+
+  if (!B.getSOAUncached(d_sd.qname, d_sd)) {
+    DLOG(g_log << "Could not get SOA for domain" << endl);
+    return;
   }
 
   DNSName before,after;