Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop explicitly requiring fakeroot #69

Merged
merged 1 commit into from
Jan 16, 2024
Merged

Conversation

zeha
Copy link
Contributor

@zeha zeha commented Jan 15, 2024

On older Debian/Ubuntu it gets installed, and dpkg-buildpackage should use it. On newer versions, we do not need it.

For further reading, see https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1041150

On older Debian/Ubuntu it gets installed, and dpkg-buildpackage should use it.
On newer versions, we do not need it.
@zeha zeha marked this pull request as ready for review January 15, 2024 10:09
@Habbie Habbie requested a review from wojas January 15, 2024 17:57
Copy link
Member

@wojas wojas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. The fakeroot would not even be needed for the other ones, because usually the builds run as root, or a 'root' faked by a rootless container runtime. If anyone is explicitly running this as a different user, fakeroot can be called explicitly in the dockerfile if needed.

The generate-dnf-provenance.py due to missing dnf module is probably unrelated, but we need to take a look at it. While at it, it's probably a good idea to enable weekly scheduled CI runs for this repo.

@Habbie
Copy link
Member

Habbie commented Jan 16, 2024

i'll have a look at the DNF stuff

@Habbie Habbie merged commit 16bc160 into PowerDNS:master Jan 16, 2024
1 check failed
@Habbie
Copy link
Member

Habbie commented Jan 16, 2024

While at it, it's probably a good idea to enable weekly scheduled CI runs for this repo.

Our yaml currently says

  # Disabled, because Github appears to disable the whole workflow if you have a schedule
  # and no updates for 60 days...
  #  schedule:
  #- cron: '0 7 * * *'

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants