build-specs.sh fails if there is no python

[Habbie]

If the Dockerfile does not have yum install -y python-rpm-macros python-srpm-macros python3-rpm-macros python34, then:

Step 30/31 : RUN builder/helpers/build-specs.sh builder-support/specs/xxx.spec
 ---> Running in d844335a3e0c
/usr/bin/env: python3: No such file or directory
+ '[' '!' -z '' ']'

it then continues to be very useless. Perhaps build-specs.sh should install these RPMs if it needs them?

[wojas]

That's indeed a bug, the build step MUST fail if python3 is not available.

Trying to install it from the build scripts would not be very consistent, as we do not do that for other things we require for building. If we would correctly fail at that point, it would be clear what is missing. Installing it automatically would make the build slower, as it will not be cached in an earlier layer and reinstalled every time the thing you are building changes.

Are you sure the python rpm macros are needed? They should only be needed if you are building python rpm packages, in which case they should be listed as some kind of Requires in the specs. Am I right here @pieterlexis?

[Habbie]

Are you sure the python rpm macros are needed?

No - I just copied that whole line from another project and then things worked :)

[Habbie]

That's indeed a bug, the build step MUST fail if python3 is not available.

Note that it does fail eventually, because the deps the spec requires are not installed and hence the actual build fails.