Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Breaking change in vscode-uri affected polymer-analyzer #3425

Closed
web-padawan opened this issue May 29, 2019 · 2 comments
Closed

Breaking change in vscode-uri affected polymer-analyzer #3425

web-padawan opened this issue May 29, 2019 · 2 comments

Comments

@web-padawan
Copy link
Contributor

web-padawan commented May 29, 2019

The vscode-uri dependency has been recently bumped to 1.0.7 and they included breaking changes in a patch release. See the commit: microsoft/vscode-uri@7f15d24

In particular, default export has been removed and changed to named export which results in errors:

error:	cli runtime exception: TypeError: Cannot read property 'file' of undefined
error:	TypeError: Cannot read property 'file' of undefined
    at new FsUrlResolver (/home/travis/build/vaadin/vaadin-time-picker/node_modules/polymer-analyzer/lib/url-loader/fs-url-resolver.js:48:55)
    at new PackageUrlResolver (/home/travis/build/vaadin/vaadin-time-picker/node_modules/polymer-analyzer/lib/url-loader/package-url-resolver.js:27:9)
    at ProjectConfig.<anonymous> (/home/travis/build/vaadin/vaadin-time-picker/node_modules/polymer-project-config/lib/index.js:301:33)
    at Generator.next (<anonymous>)
    at /home/travis/build/vaadin/vaadin-time-picker/node_modules/polymer-project-config/lib/index.js:20:71
    at new Promise (<anonymous>)
    at __awaiter (/home/travis/build/vaadin/vaadin-time-picker/node_modules/polymer-project-config/lib/index.js:16:12)
    at ProjectConfig.initializeAnalyzer (/home/travis/build/vaadin/vaadin-time-picker/node_modules/polymer-project-config/lib/index.js:299:16)
    at Object.<anonymous> (/home/travis/build/vaadin/vaadin-time-picker/node_modules/polymer-cli/lib/lint/lint.js:74:82)

In the meanwhile, as a workaround we have to pin to =1.0.6 explicitly.

@web-padawan
Copy link
Contributor Author

Reported at microsoft/vscode#74533

@web-padawan
Copy link
Contributor Author

The original issue has been fixed, closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant