Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Declare peer dependencies for web-component-tester #3397

Open
nicojs opened this issue Apr 10, 2019 · 3 comments
Open

Declare peer dependencies for web-component-tester #3397

nicojs opened this issue Apr 10, 2019 · 3 comments
Labels

Comments

@nicojs
Copy link

nicojs commented Apr 10, 2019

The README.md file of web-component-tester currently states the following:

You get a browser-based testing environment, configured out of the box with:

  • Mocha as a test framework.
  • Chai assertions.
    [...]
  • Sinon and sinon-chai to test just your things.

However, sinon, chai and mocha are not dependencies or peerDependencies of web-component-tester itself. You're apparently expected to 'bring-your-own' when using WCT. This is a very brittle construction at best since you're immune to breaking changes announcements. This is the root cause for issue #3394

The best solution would be to include the required plugins and let WCT come with "batteries included". If for some reason you don't want to do that, we should at least declare the manual dependencies as peerDependencies, so that we know what to install and maintain.

@stale
Copy link

stale bot commented Apr 9, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix label Apr 9, 2020
@nicojs
Copy link
Author

nicojs commented Apr 9, 2020

Hello? Any maintainers?

@stale stale bot removed the wontfix label Apr 9, 2020
@stale
Copy link

stale bot commented Jun 2, 2021

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix label Jun 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant