Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop Python 3.9 support #244

Closed
martinholmer opened this issue Aug 10, 2024 · 1 comment · Fixed by #286
Closed

Drop Python 3.9 support #244

martinholmer opened this issue Aug 10, 2024 · 1 comment · Fixed by #286
Labels
good first issue Good for newcomers

Comments

@martinholmer
Copy link

martinholmer commented Aug 10, 2024

The following line 6 does not work under Python 3.9 because the | notation for Union was introduced into Python typing beginning with Python 3.10.

from typing import Sequence, TypeVar, Any
from numpy.typing import NDArray as ArrayType
T = TypeVar("T", bool, bytes, float, int, object, str)
ArrayLike = ArrayType[Any] | Sequence[T]

I suggest revising setup.py to require Python 3.10, 3.11, or 3.12.

@MaxGhenis MaxGhenis added the good first issue Good for newcomers label Aug 10, 2024
@MaxGhenis MaxGhenis changed the title Using Python 3.9 causes error Drop Python 3.9 support Sep 21, 2024
SylviaDu99 added a commit to SylviaDu99/policyengine-core that referenced this issue Oct 1, 2024
@anth-volk
Copy link
Contributor

Closed as part of #286.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants