Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add inclusive / exclusive metadata tag to scale parameters #221

Open
PavelMakarchuk opened this issue Jul 10, 2024 · 1 comment
Open

Add inclusive / exclusive metadata tag to scale parameters #221

PavelMakarchuk opened this issue Jul 10, 2024 · 1 comment
Assignees
@PavelMakarchuk

Comments

@PavelMakarchuk
Copy link
Collaborator

This should then also be displayed in the web app to make it easier to understand whether the bracket that is being adjusted is exclusive or inclusive
@PavelMakarchuk PavelMakarchuk self-assigned this Jul 10, 2024
PavelMakarchuk added a commit that referenced this issue Jul 10, 2024
@PavelMakarchuk
Add inclusive / exclusive metadata tag to scale parameters
7e9f32b 
Fixes #221
@PavelMakarchuk PavelMakarchuk mentioned this issue Jul 10, 2024
Closed
@MaxGhenis
Copy link
Contributor

Should we add this without integrating it into logic? This would be a significant change if not. We could make it purely aesthetic but that could conflict with the actual logic. Also should we require it for thresholds/limits?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@PavelMakarchuk PavelMakarchuk

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add inclusive / exclusive metadata tag to scale parameters PolicyEngine/policyengine-core
2 participants
@MaxGhenis @PavelMakarchuk