Merge pull request #132 from PolicyEngine/nikhilwoodruff/issue131

MaxGhenis · web-flow · commit ae95e4cdc293 · 2023-11-30T13:44:46.000-05:00
Fix subtracts class type
diff --git a/changelog_entry.yaml b/changelog_entry.yaml
@@ -0,0 +1,4 @@
+- bump: patch
+  changes:
+    fixed:
+    - Bug causing `subtracts` to not accept strings.
diff --git a/policyengine_core/variables/variable.py b/policyengine_core/variables/variable.py
@@ -256,7 +256,7 @@ def __init__(self, baseline_variable=None):
         )
 
         self.adds = self.set(attr, "adds")
-        self.subtracts = self.set(attr, "subtracts", allowed_type=list)
+        self.subtracts = self.set(attr, "subtracts")
         self.uprating = self.set(attr, "uprating", allowed_type=str)
         self.hidden_input = self.set(
             attr, "hidden_input", allowed_type=bool, default=False

Original file line number	Diff line number	Diff line change
`@@ -256,7 +256,7 @@ def __init__(self, baseline_variable=None):`
`256`	`256`	`)`
`257`	`257`
`258`	`258`	`self.adds = self.set(attr, "adds")`
`259`		`- self.subtracts = self.set(attr, "subtracts", allowed_type=list)`
	`259`	`+ self.subtracts = self.set(attr, "subtracts")`
`260`	`260`	`self.uprating = self.set(attr, "uprating", allowed_type=str)`
`261`	`261`	`self.hidden_input = self.set(`
`262`	`262`	`attr, "hidden_input", allowed_type=bool, default=False`