Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Paging through annotations fails when document is visited from annotation-specific URL #211

Open
codyml opened this issue Dec 5, 2017 · 0 comments
Labels

Comments

@codyml
Copy link
Contributor

codyml commented Dec 5, 2017

When an annotation on a document is visited using its direct link (document URL with ?id=XXX), the pager buttons don't work right away and cause the attached error. Neither of the "None," "Mine," or "All" buttons are selected either. Selecting one of these buttons makes paging through annotations work again.

js_NnoPHN7yKs4UpwICVDR-tCcYvswoIoRqJrkmQchqAhI.js:603 Uncaught TypeError: Cannot read property 'highlights' of undefined
    at PTController.check_if_annotation_visible (js_NnoPHN7yKs4UpwICVDR-tCcYvswoIoRqJrkmQchqAhI.js:603)
    at HTMLDocument.<anonymous> (js_NnoPHN7yKs4UpwICVDR-tCcYvswoIoRqJrkmQchqAhI.js:532)
    at HTMLDocument.dispatch (js_9ghOzpywkUSGMtnNnMGS7mA2XEN0DUwNX9wpktc9bCo.js:3)
    at HTMLDocument.i (js_9ghOzpywkUSGMtnNnMGS7mA2XEN0DUwNX9wpktc9bCo.js:3)
    at Object.trigger (js_9ghOzpywkUSGMtnNnMGS7mA2XEN0DUwNX9wpktc9bCo.js:3)
    at HTMLDocument.<anonymous> (js_9ghOzpywkUSGMtnNnMGS7mA2XEN0DUwNX9wpktc9bCo.js:3)
    at Function.each (js_9ghOzpywkUSGMtnNnMGS7mA2XEN0DUwNX9wpktc9bCo.js:2)
    at $.fn.init.each (js_9ghOzpywkUSGMtnNnMGS7mA2XEN0DUwNX9wpktc9bCo.js:2)
    at $.fn.init.trigger (js_9ghOzpywkUSGMtnNnMGS7mA2XEN0DUwNX9wpktc9bCo.js:3)
    at Filters.Annotator.Plugin.Filters.Filters.pagerClick (js_MW6BUpL3plJBXcwx5KHY0doSU7EhY8GRrdua4rmUGOw.js:10424)
@codyml codyml added the bug label Dec 5, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant