Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The Kidnapping of Boo: Bug in kicking/Adding back Minsc in the Party #40

Open
Frenzgyn opened this issue Oct 21, 2023 · 3 comments
Open
Assignees
Labels

Comments

@Frenzgyn
Copy link

Frenzgyn commented Oct 21, 2023

I noticed a strange bug after I resolve the quest (Fighting Elyanna guards or Peacefully resolved).

Minsc get back Boo but keeps Boo's scraps (WWEBOO.ITM) (as in https://github.com/Pocket-Plane-Group/UnfinishedBusiness/issues/24) and the dialogue after kicking him from the party doesn't trigger.
He comes to player1 to initiate dialogue, but it bugs and you could not talk anymore with him.
It's probably due to trigger 1 in MINSCP.DLG:

HasItem("wweboo","Minsc") // Boo's scraps.
!HasItem("MISC84","Minsc") // Boo
---> So, in this case we have both item and the condition is false
!Global("WWBetrayedMinsc","GLOBAL",1)
Global("WWLeave","LOCALS",0)

And trigger 5 and 6 too:
!HasItem("wweboo","Minsc") // Boo's scraps. ---> Same here.

Removing WWEBOO.ITM with NI fix the issue, probably the issue is like the example in wwelspl.baf:

IF
	True()
THEN
	RESPONSE #100
	CutSceneId("WWElle")
	ReallyForceSpell(Myself,CLERIC_HEAL)
	DestroyItem("wweboo")  /* Kulyok v25 */
	Wait(1)
	MoveToObject("Minsc")
	DisplayStringHead(Myself,@36)
	ForceSpell(Myself,FLASHY_1)
	Wait(2)
	DisplayStringHead(Myself,@37)
	Wait(2)
	ForceSpell(Myself,CLERIC_CALL_LIGHTNING)
	DisplayStringHead(Myself,~Ouch!~)
	Wait(2)
	ForceSpell("Minsc",FLASHY_2)
	Wait(1)
	DisplayStringHead(Myself,~That's it!~)
	ReallyForceSpell(Myself,CLERIC_HEAL)
	ReallyForceSpell(Myself,WIZARD_FLAME_ARROW)
	Wait(2)
        SetGlobal("WWAfterSpell","LOCALS",1)
	EndCutSceneMode()
END

Adding a "TakePartyItem("wweboo")" before "DestroyItem("wweboo") seems to fix the issue (in the specific case of 3 correct answers to the Elyanna's riddles).

Various similar lines in "wwminscub.d" should hopefully fix the other endings (fight, 1 correct answer and two correct answers).

@Frenzgyn Frenzgyn changed the title The Kidnapping of Boo *possible* Bug The Kidnapping of Boo: Bug in kicking/Adding back Minsc in the Party Oct 21, 2023
@AngelGryph AngelGryph self-assigned this Oct 23, 2023
@AngelGryph AngelGryph added the bug label Oct 23, 2023
@AngelGryph
Copy link
Collaborator

Confirmed, there are compatibility issues between Minsc's quest in UB and the Tweaks (formerly SCS) component that moves Boo to Minsc's inventory, something which the UB scripts don't anticipate. I'll probably have to commune with CamDawg and/or DavidW on how we can make this as robust as possible, but I'll make the suggested dialog changes.

@Frenzgyn
Copy link
Author

Never tried the quest without CDTweaks (I don't use SCS at the moment), does Boo's scraps too go in the quickslot by default wit UB?

Anyway, thank you for the time you spend supporting all the older mods.

@AngelGryph
Copy link
Collaborator

Yes, oBG2 did not have the TransformItem action, so the change was implemented through a spell using opcode 143 (Create Item in Slot) instead.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants