Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

_refresh not being called in update request #30

Open
HetIsJoey opened this issue Nov 5, 2021 · 2 comments
Open

_refresh not being called in update request #30

HetIsJoey opened this issue Nov 5, 2021 · 2 comments

Comments

@HetIsJoey
Copy link
Contributor

_refresh not being called when receiving 401 error in update request.

Is this intentional or?
@Plazide
Copy link
Owner

Plazide commented Nov 5, 2021

I believe that is a mistake. It does not seem correct that the request is retried without some kind of modification. I believe there should be a this._refresh() call within the if block before the request is called again.

Good catch! Feel free to open a PR to fix this.

@malekashkar
Copy link
Contributor

You can close this issue now right?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@HetIsJoey @Plazide @malekashkar