Verified / Top Projects - Open Points #408
Labels
Comments
mohitb35
changed the title
|
#407 (comment): Since Mui Icon is only being used at one place i.e. for verified projects, this change doesn't affect any other places. |
mohitb35
added a commit
that referenced
this issue
May 18, 2023
- creates ProjectTitle component with simplified code - extracts VerifiedBadge (popover) code to separate component - moves specific component styles - from global styles (donations.scss) - moves mui theme based styles to theme - separates logic to show project info from render statement - gives a min width to popover (refer #408) - removes code duplication of popover code (ref #408) - aligns verified icon and project title (ref #408)
|
@prachigarg19 Should be resolved in a5947d6 |
mohitb35
added a commit
that referenced
this issue
May 18, 2023
- creates ProjectTitle component with simplified code - extracts VerifiedBadge (popover) code to separate component - moves specific component styles - from global styles (donations.scss) - moves mui theme based styles to theme - separates logic to show project info from render statement - gives a min width to popover (refer #408) - removes code duplication of popover code (ref #408) - aligns verified icon and project title (ref #408)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1. #407 (comment) - confirm that this style change does not affect other places.2. #407 (comment) - responsive width for popover3. #407 (comment) - slight misalignment of verified icon and project name (nit)
4. #407 (comment) - address code duplicationThe text was updated successfully, but these errors were encountered: