Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Duplicated fragment code in BasisCurves.glslfx #3132

Closed
PierreWang opened this issue Jun 20, 2024 · 2 comments
Closed

Duplicated fragment code in BasisCurves.glslfx #3132

PierreWang opened this issue Jun 20, 2024 · 2 comments

Comments

@PierreWang
Copy link
Contributor

Description of Issue

In change 56e3997, some common shading code are moved to terminals.glslfx. But he forgot to remove the corresponding snippets in BasisCurves.Fragment of BasisCurves.glslfx. And then in the following change, the removed snippets for Curves.Fragment.Wire is incorrectly returned back at change b3e6fee.

So now, ApplyColorOverrides and LightingBlend are firstly called in the Curves.Fragment.Wire and Curves.Fragment.Patch shader code, and then called again in the ShadingTerminal code. This should be a duplication.

We have created a PR 3124 for this issue.

@jesschimein
Copy link
Contributor

Filed as internal issue #USD-9781

@dgovil
Copy link
Collaborator

dgovil commented Oct 31, 2024

Closing because #3124 has been merged.

@dgovil dgovil closed this as completed Oct 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants