You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
In change 56e3997, some common shading code are moved to terminals.glslfx. But he forgot to remove the corresponding snippets in BasisCurves.Fragment of BasisCurves.glslfx. And then in the following change, the removed snippets for Curves.Fragment.Wire is incorrectly returned back at change b3e6fee.
So now, ApplyColorOverrides and LightingBlend are firstly called in the Curves.Fragment.Wire and Curves.Fragment.Patch shader code, and then called again in the ShadingTerminal code. This should be a duplication.
Description of Issue
In change 56e3997, some common shading code are moved to terminals.glslfx. But he forgot to remove the corresponding snippets in BasisCurves.Fragment of BasisCurves.glslfx. And then in the following change, the removed snippets for Curves.Fragment.Wire is incorrectly returned back at change b3e6fee.
So now, ApplyColorOverrides and LightingBlend are firstly called in the Curves.Fragment.Wire and Curves.Fragment.Patch shader code, and then called again in the ShadingTerminal code. This should be a duplication.
We have created a PR 3124 for this issue.
The text was updated successfully, but these errors were encountered: