Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SONAME is incorrect #1240

Open
yurivict opened this issue Dec 5, 2021 · 2 comments
Open

SONAME is incorrect #1240

yurivict opened this issue Dec 5, 2021 · 2 comments

Comments

@yurivict
Copy link

yurivict commented Dec 5, 2021

SONAME is set to libosdCPU.so.3.4.4.
It is supposed to be libosdCPU.so.3 or libosdCPU.so.3.4 to allow space for minor version updates not requiring rebuild of all dependencies.
There should also be a corresponding shared link with the same name as SONAME.

@jilliene
Copy link

jilliene commented Dec 9, 2021

Filed as internal issue #OSD-366

@davidgyu
Copy link
Member

Thanks, this is a good suggestion. Currently, we include the patch version number as well as the major and minor versions in our name spacing of symbols. So, the SONAME is consistent with that behavior, i.e. patch version releases introduce new link symbols.
We've discussed changing this name space policy, and if we do make a change we'll make sure to update the SONAME as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants