Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

php short tags #62

Open
osworx opened this issue Sep 29, 2023 · 0 comments
Open

php short tags #62

osworx opened this issue Sep 29, 2023 · 0 comments

Comments

@osworx
Copy link
Contributor

osworx commented Sep 29, 2023

<li class="path-ext-<?=$item["path_ext"]?> file-ext-<?=$item["file_ext"]?>" style=width:<?=$csize[0]?>px;height:<?=$row_height?>px><a href="<?=$item['URL']?>"<?=$a_style?>><img src="<?=$c->get_url()?>" width=<?=$csize[0]?> height=<?=$csize[1]?> alt="<?=$item['TN_ALT']?>"></a><div class=overDesc><?=$item['NAME']?><?=$new?></div></li>

Is that intended to use short tags?
If, this will make troubles on systems where short_tags are not enabled.
Maybe replace them with full opening tags <?php to be consistent with the whole system.

Also in this file a mixture of used { } and not used { } at if .. elseif .. else (jus a sample of what I have meant it's sometimes hard to read the code ..

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant