Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Images showing at reduced size on high resolution displays #48

Open
okyeron opened this issue May 18, 2022 · 2 comments
Open

Images showing at reduced size on high resolution displays #48

okyeron opened this issue May 18, 2022 · 2 comments

Comments

@okyeron
Copy link

okyeron commented May 18, 2022

On my newish M1 Macbook Pro I was noticing that images which should have been displaying at "original" size were showing at a smaller size instead. In this case a 720x480 image was showing at half that.

Digging into the code in photo.autosize.js I found that when available.dpr = 2 (in my case) then line 10 would return an image half as big as it should

return {w: Math.round(d.w / available.dpr), h: Math.round(d.h / available.dpr)};

For the moment I've modified my installation to just use {w: Math.round(d.w), h: Math.round(d.h)}

@plegall
Copy link
Member

plegall commented Sep 29, 2023

Hi @okyeron

We've been discussing this issue this week during a dev/design meeting. Here are the conclusions for now:

  1. rework the default dimensions (in pixels) for each multiple size (XSS to XXL). Indeed in Piwigo 14, XXL is 1656 pixels wide. It seems big but with a DPR of 2, it means a display at 1656/2=828 pixels, which is not that much, especially on a macbook 16 inches (or even on a 14 inches like the one I work on). If the XXL was, let's say, 2000 pixels wide, it would be displayed on 1000 pixels. Maybe it's not even enough.
  2. the DPR=2 is applied only on the automatically selected size displayed. When you select another size, we go back to DPR=1, which means, that size XL (1224 pixels wide) is much bigger in display than XXL with DPR=2. It is very annoying. Modus should apply the same DPR whatever the size displayed.
  3. add an option for administrators to deactivate the use of DPR, meaning a 1656 pixels wide XXL would be displayed on 1656 pixels, no matter you're on a retina screen.
  4. distinguish thumbnails page and photo page to activate/deactivate DPR

We don't put that on the top priority but I came across your issue and wanted to let you know we're aware of this problem (I personnaly am because I recently switched to retina display)

@Michael-B-High
Copy link
Contributor

Michael-B-High commented Mar 6, 2024

I was at the point of raising a new request when I came across this thread. I am wanting to migrate to Modus as it is the best fit to my wish list. However, it is essentially broken on the Photo page, the Slideshow and in the Category pages. It works really well if I put my 2019 iMac into developer mode, which turns off the Retina display. In the default mode and preferred alternative display sizes all my images come up half size as these settings are Retina enabled. I have noticed that one of the Piwigo reference sites (https://photos.icam.fr) is similarly broken.
Is this issue rising up the list of priorities? Is there anything that I can do to help, as a non-technical end user?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants