Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

justify/masonry style layout broken when thumbnail size is set above XS #11

Open
jjemil749 opened this issue May 29, 2019 · 1 comment

Comments

@jjemil749
Copy link

Modus Theme stops applying the masonry style layout when thumbnail size is set above XS.
This has been confirmed as well by another user.

Discussion thread: https://piwigo.org/forum/viewtopic.php?id=29316

@dae1804
Copy link

dae1804 commented Nov 7, 2019

This looks to be deliberate -- see line 2 in thumbnails.tpl: there's an explicit check to see if $derivative_params->max_height()<400. Changing 400 to (e.g.) 600 allows "small" size images to display. It looks like this limit was raised from 400 to 480 in a867f0d, then reverted to 400 in 2e67776 without comment.

What's the rationale for disallowing fluid mode for larger thumbnail sizes? The code seems to suggest concerns about not fitting at least one image per row -- is this a hack around a CSS issue? At minimum, can an option be added to make this threshold user-configurable?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants